Improve .razor.css cleanup in boilerplate (#10955)

[Md23Mh]

closes #10955

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of orphaned .razor.css files to prevent build errors by ensuring they are deleted when no matching .razor file exists.

• Documentation

  • Updated comments to clarify the behavior of deleting unmatched .razor.css files.

[coderabbitai]

Walkthrough

The MSBuild target DeleteUnmatchedRazorCss in the project configuration was updated. The logic now deletes .razor.css files that do not have a corresponding .razor file, instead of checking for .razor.scss files. Comments were revised to clarify this updated behavior.

Changes

File(s)	Change Summary
src/Templates/Boilerplate/.../Directory.Build.props	Updated comments and modified MSBuild logic to delete .razor.css files lacking a .razor file.

Assessment against linked issues

Objective	Addressed	Explanation
Update DeleteUnmatchedRazorCss to delete .razor.css files only if the corresponding .razor file is missing (#10955)	✅
Remove dependency on .razor.scss existence for orphan detection (#10955)	✅
Improve comments to clarify the new logic and rationale (#10955)	✅

Poem

In the meadow of code, where the Razor files grow,
A rabbit hopped by, tidying as they go.
No orphaned CSS left behind in the sun,
Only matched pairs—cleanup is done!
With logic renewed and comments so clear,
The build is now happy—let’s all give a cheer!
🐇✨

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props (1)

90-91: Improved logic for detecting orphaned CSS files.

The change from checking for .scss files to checking for the base .razor file is more comprehensive and appropriate. This will catch orphaned .razor.css files regardless of whether they were generated from .scss or directly from .razor files.

However, consider using forward slashes for better cross-platform compatibility:

-            <RazorCssFiles Include="**\*.razor.css" />
+            <RazorCssFiles Include="**/*.razor.css" />

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 6198ee8 and a7cfbaa.

📒 Files selected for processing (1)

• src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build and test

🔇 Additional comments (2)

src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props (2)

81-87: Well-documented target purpose and behavior.

The updated comments clearly explain the scenario where orphaned .razor.css files can cause build errors and how this target addresses the issue.

---

88-94: Target timing and implementation are appropriate.

Running this target before ComputeCssScope ensures orphaned CSS files are cleaned up before they can cause build errors. The implementation correctly identifies and deletes unmatched files.