Fix race condition in popup based social sign-in (#10941) #10942

ysmoradi · 2025-06-07T18:38:13Z

Summary by CodeRabbit

Refactor
- Simplified the logic for handling the return URL after sign-in, ensuring users are redirected to the home page if no return URL is provided.

coderabbitai · 2025-06-07T18:38:19Z

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The logic for determining the ReturnUrl in the sign-in panel was simplified. Now, when the ReturnUrlQueryString is null, the code directly defaults to the home page URL instead of first attempting to use the navigation manager's relative path.

Changes

File(s)	Change Summary
.../Boilerplate.Client.Core/Components/Pages/Identity/SignIn/SignInPanel.razor.cs	Simplified `ReturnUrl` property logic to default to home page if query string is null.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SignInPanel
    participant Urls

    User->>SignInPanel: Initiates sign-in
    SignInPanel->>SignInPanel: Check ReturnUrlQueryString
    alt ReturnUrlQueryString is not null
        SignInPanel->>User: Use ReturnUrlQueryString
    else ReturnUrlQueryString is null
        SignInPanel->>Urls: Use HomePage URL
        SignInPanel->>User: Use HomePage as ReturnUrl
    end

Assessment against linked issues

Objective	Addressed	Explanation
Handle sign-in page logic when return-url is missing (#10941)	✅

Poem

In the warren of code, a path once unclear,
Now leads straight home, with logic sincere.
No more winding ways or fallback in sight,
The sign-in returns where all feels right.
🐇✨ Homeward bound, with code so neat—
This bunny approves the simplified feat!

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Copilot

Pull Request Overview

This PR ensures that when no return-url query parameter is provided, the sign-in panel falls back directly to the home page instead of the current relative path.

Removed the NavigationManager.GetRelativePath() fallback from the ReturnUrl property.
Now defaults to Urls.HomePage when ReturnUrlQueryString is null.

Comments suppressed due to low confidence (2)

src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/SignIn/SignInPanel.razor.cs:21

Consider adding unit tests to cover the ReturnUrl property, verifying both the case when ReturnUrlQueryString is provided and when it is null to ensure the fallback to HomePage works as intended.

private string ReturnUrl => ReturnUrlQueryString ?? Urls.HomePage;

src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/SignIn/SignInPanel.razor.cs:21

[nitpick] Add a summary comment on the ReturnUrl property explaining that it falls back to the home page when no return-url query string is present.

private string ReturnUrl => ReturnUrlQueryString ?? Urls.HomePage;

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/SignIn/SignInPanel.razor.cs (1)
186-186: Remove redundant null check.

Since ReturnUrl now always returns a non-null value (either ReturnUrlQueryString or Urls.HomePage), the null coalescing operator is redundant.

Apply this diff to simplify the navigation call:
-NavigationManager.NavigateTo(ReturnUrl ?? Urls.HomePage, replace: true);
+NavigationManager.NavigateTo(ReturnUrl, replace: true);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 220c146 and 8b4931f.

📒 Files selected for processing (1)

src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/SignIn/SignInPanel.razor.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: build and test

🔇 Additional comments (1)

src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/SignIn/SignInPanel.razor.cs (1)

21-21: LGTM! Simplified ReturnUrl logic resolves the issue.

This change effectively fixes the sign-in page issue by removing the problematic fallback to NavigationManager.GetRelativePath() and directly defaulting to Urls.HomePage when no return URL is provided. The simplified implementation is more predictable and should resolve the reported issue.

fix issue with sign-in page without return-url (#10941)

8b4931f

ysmoradi requested review from Copilot and msynk June 7, 2025 18:38

Copilot AI reviewed Jun 7, 2025

View reviewed changes

coderabbitai bot reviewed Jun 7, 2025

View reviewed changes

ysmoradi added 7 commits June 7, 2025 20:51

fix

69e59bf

fix

a5e2286

fix

13ef659

fix

8ec14d0

fix

616a0bb

fix

9f0014c

fix

7b9350b

ysmoradi temporarily deployed to production June 7, 2025 20:42 — with GitHub Actions Inactive

ysmoradi added 5 commits June 8, 2025 11:48

fix

109756d

fix

b151e77

fix

4ccbeee

fix

6004276

fix

0a3b465

ysmoradi temporarily deployed to production June 8, 2025 10:49 — with GitHub Actions Inactive

ysmoradi temporarily deployed to production June 8, 2025 11:00 — with GitHub Actions Inactive

ysmoradi temporarily deployed to production June 8, 2025 11:03 — with GitHub Actions Inactive

ysmoradi temporarily deployed to production June 8, 2025 11:05 — with GitHub Actions Inactive

ysmoradi temporarily deployed to production June 8, 2025 11:14 — with GitHub Actions Inactive

ysmoradi added 3 commits June 8, 2025 13:25

fix

f71d17a

fix

ae16ad6

fix

4749129

ysmoradi changed the title ~~Fix issue with sign-in page without return-url (#10941)~~ Fix race condition in modal/popup based social sign-in (#10941) Jun 8, 2025

ysmoradi changed the title ~~Fix race condition in modal/popup based social sign-in (#10941)~~ Fix race condition in popup based social sign-in (#10941) Jun 8, 2025

ysmoradi merged commit 35ce25a into bitfoundation:develop Jun 8, 2025
3 checks passed

ysmoradi deleted the 10941 branch June 8, 2025 13:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix race condition in popup based social sign-in (#10941) #10942

Fix race condition in popup based social sign-in (#10941) #10942

Uh oh!

ysmoradi commented Jun 7, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 7, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Copilot AI left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Fix race condition in popup based social sign-in (#10941) #10942

Fix race condition in popup based social sign-in (#10941) #10942

Uh oh!

Conversation

ysmoradi commented Jun 7, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ysmoradi commented Jun 7, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)