Fix issues of state changes in BitSearchBox (#10928)

[msynk]

closes #10928

Summary by CodeRabbit

• Style
  • Minor formatting adjustments were made to improve code readability. No visible changes to the user interface or functionality.

[coderabbitai]

Walkthrough

The code reorders the private asynchronous methods ToggleCallout and CloseCallout within the BitSearchBox.razor.cs file, removing and then reintroducing them with unchanged logic. A minor formatting adjustment is made in the OpenOrCloseCallout method by moving the StateHasChanged() call outside the conditional block.

Changes

File(s)	Change Summary
src/BlazorUI/Bit.BlazorUI/.../BitSearchBox.razor.cs	Reordered and reintroduced ToggleCallout and CloseCallout methods with no logic changes; minor formatting update in OpenOrCloseCallout.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure BitSearchBox suggestions update correctly based on input (Issue #10928)	❌	No changes to filtering or suggestion logic are present; only method order and formatting adjusted.

Assessment against linked issues: Out-of-scope changes

Code Change	Explanation
Reordering and reintroduction of private methods (BitSearchBox.razor.cs)	The changes are unrelated to the issue's objective, which concerns suggestion filtering logic.

Poem

A bunny hopped through code today,
Rearranged some methods, neat and gray.
No new logic, just a tidy sweep,
The search box secrets it did keep.
Next time, perhaps, suggestions will play—
For now, just order leads the way!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/BlazorUI/Bit.BlazorUI/Components/Inputs/SearchBox/BitSearchBox.razor.cs (1)

437-445: Reintroduced CloseCallout implementation
The method was removed earlier and added back with identical logic. No functional change detected. Consider grouping private helper methods coherently (e.g., alphabetically or by feature) to maintain file organization.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between bf631f1 and 9090100.

📒 Files selected for processing (1)

• src/BlazorUI/Bit.BlazorUI/Components/Inputs/SearchBox/BitSearchBox.razor.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build and test

🔇 Additional comments (2)

src/BlazorUI/Bit.BlazorUI/Components/Inputs/SearchBox/BitSearchBox.razor.cs (2)

428-429: StateHasChanged repositioned
Moved the StateHasChanged() call outside the inner if (_isOpen == false) block to fire on every render pass when suggestions exist. Verify this aligns with the intended open-state UI behavior and doesn’t introduce unnecessary re-renders.

---

447-466: Reintroduced ToggleCallout implementation
Same implementation moved within the file. Ensure _dotnetObj and _Id are initialized before this JS interop call to avoid null-reference or runtime errors.