Skip to content

Conversation

mcbabo
Copy link

@mcbabo mcbabo commented Sep 19, 2025

Purpose

Fixes #712

Adds insets when phone is landscape

Short description

Adds .windowInsetsPadding(WindowInsets.safeDrawing.only(WindowInsetsSides.Horizontal)) to each top child in a Scaffold

Needs proper testing before merge!

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2025

CLA assistant check
All committers have signed the CLA.

@sunkup
Copy link
Member

sunkup commented Sep 24, 2025

@mcbabo

Thank you for the contribution and your involvement. It's a good start! I tested it and I think it'd be better if the loading bar (blue animated top stripe shown on refresh) would not receive the padding. See the screenshot.

Screenshot from 2025-09-24 13-24-06

So applying the window insets padding to

  • LazyColumn in CalendarListContent in SubscriptionsScreen
  • HorizontalPager in EnterUrlComposable (instead of AddSubscriptionScreen)
  • Column in SubscriptionSettingsComposable (instead of AddSubscriptionScreen)

would look better, since the loading bar will be able to stretch the whole screen width (up to the 3-button navigation) again.

Additionally it would be cool if you could also add the window insets padding to the FloatingActionButton in SubscriptionsScreen as that one seems to go below the 3-button navigation in landscape mode.

Again, thanks for the help. We appreciate it!

@sunkup sunkup added the bug Something isn't working label Sep 24, 2025
@sunkup sunkup added this to the 2.4.3 milestone Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content in landscape mode below cut out areas
3 participants