Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard content provider instead of TaskProvider in TaskSyncer #982

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

sunkup
Copy link
Member

@sunkup sunkup commented Aug 14, 2024

Purpose

Before bitfireAT/ical4android#161 TaskSyncer had to acquire TaskProvider in order to find the local tasks list or create a local task list. Now it can use the normal content provider client from Syncer.

bitfireAT/ical4android#161 did also update the DmfsTaskList to hold a standard content provider instead of a task provider so we need to update its usages as well.

Short description

  • Updates TaskSyncer to use the standard content provider from base class Syncer.
  • Still checks whether the (Task-) provider is too old.
  • Updates LocalTaskList and LocalTask which inherit and use DmfsTaskList to use the standard content provider. TaskProvider held the actual content provider client in it's "client" property. Now we can use the provider directly.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup sunkup added the refactoring Internal improvement of existing functions label Aug 14, 2024
@sunkup sunkup self-assigned this Aug 14, 2024
@sunkup sunkup linked an issue Aug 14, 2024 that may be closed by this pull request
@sunkup sunkup requested a review from ArnyminerZ August 14, 2024 11:29
Copy link
Member

@ArnyminerZ ArnyminerZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sunkup sunkup requested a review from rfc2822 August 15, 2024 10:26
@sunkup sunkup requested a review from rfc2822 August 19, 2024 07:56
@sunkup sunkup force-pushed the 964-tasksyncer-dont-acquire-taskprovider branch from cde9e8a to 4f4983a Compare August 20, 2024 08:27
@sunkup sunkup requested review from rfc2822 and removed request for rfc2822 August 20, 2024 08:31
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@rfc2822 rfc2822 merged commit b962b68 into main-ose Aug 20, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 964-tasksyncer-dont-acquire-taskprovider branch August 20, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TaskSyncer: Don't acquire TaskProvider
3 participants