Tests for sync algorithm #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunkup
force-pushed
the
950-tests-for-sync-algorithm
branch
from
c452bde to
e3afd4a
Compare
|
Note: @ArnyminerZ tests are failing due to |
ArnyminerZ
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Looks good to me, and as you have said, runs correctly locally.
The only thing that bothers me a bit is the getters for TestSyncer
override val authority: String
get() = ""
override val serviceType: String
get() = ""but it doesn't matter, so I guess it can be like that without any issues.
rfc2822
reviewed
Aug 17, 2024
app/src/androidTest/kotlin/at/bitfire/davdroid/sync/SyncerTest.kt
Outdated
Show resolved
Hide resolved
- update comments - update test method spacing - replace empty array method
rfc2822
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Tests for the sync algorithm.
Short description
I have tried to have a single test for one specific behaviour only. So the tests are very verbose on purpose.
Checklist