Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dav4jvm for better logging #956

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Update dav4jvm for better logging #956

merged 2 commits into from
Aug 5, 2024

Conversation

ArnyminerZ
Copy link
Member

@ArnyminerZ ArnyminerZ commented Aug 5, 2024 •
edited by rfc2822
Loading

Purpose

Upgrade dav4jvm to the latest version.

Short description

Introduced XmlReader.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@ArnyminerZ
Upgrade dav4jvm
e68f18f 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Using XmlReader
fa1170e 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ self-assigned this Aug 5, 2024
@ArnyminerZ ArnyminerZ linked an issue Aug 5, 2024 that may be closed by this pull request
Update dav4jvm for better logging #954
Closed
@ArnyminerZ ArnyminerZ marked this pull request as ready for review August 5, 2024 14:12
@ArnyminerZ ArnyminerZ requested a review from rfc2822 August 5, 2024 14:13
rfc2822
rfc2822 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, only one change. Expected more to fail ;)

PS please always delete this:

Bildschirmfoto vom 2024-08-05 16-37-43

@rfc2822 rfc2822 merged commit 5cbbfb3 into main-ose Aug 5, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 954-update-dav4jvm-for-better-logging branch August 5, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfc2822 rfc2822 rfc2822 approved these changes

Assignees

@ArnyminerZ ArnyminerZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update dav4jvm for better logging
2 participants
@ArnyminerZ @rfc2822