Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug info: Sync interval "0 min" when actually -1 (manual) #928

Merged

Conversation

ArnyminerZ
Copy link
Member

The PR should be in Draft state during development. As soon as it's finished, it should be marked as Ready for review and a reviewer should be chosen.

See also: Writing A Great Pull Request Description

Purpose

See #905

Short description

Only taking sync interval if >= 0

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ linked an issue Jul 20, 2024 that may be closed by this pull request
@ArnyminerZ ArnyminerZ requested a review from sunkup July 20, 2024 09:33
@ArnyminerZ ArnyminerZ self-assigned this Jul 20, 2024
@ArnyminerZ ArnyminerZ added the enhancement New feature or request label Jul 20, 2024
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@ArnyminerZ ArnyminerZ marked this pull request as ready for review July 22, 2024 18:08
@rfc2822 rfc2822 merged commit 73d0b63 into main-ose Jul 23, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 905-debug-info-sync-interval-0-min-when-actually-1-manual branch July 23, 2024 17:08
@rfc2822 rfc2822 added bug Something isn't working and removed enhancement New feature or request labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug info: Sync interval "0 min" when actually -1 (manual)
3 participants