Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SyncManager: pass collection directly #927

Merged
merged 9 commits into from
Aug 5, 2024
Merged

SyncManager: pass collection directly #927

merged 9 commits into from
Aug 5, 2024

Conversation

ArnyminerZ
Copy link
Member

@ArnyminerZ ArnyminerZ commented Jul 20, 2024 •
edited by rfc2822
Loading

Purpose

After #875, we will have direct access to the DB collection. So we don't need to find it manually in saveSyncTime anymore and can directly use the passed collection.

Short description

Using the passed collection

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@ArnyminerZ
Passing collection directly
2ce9c78 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ linked an issue Jul 20, 2024 that may be closed by this pull request
SyncManager: log last sync time directly to DB collection #876
Closed
@ArnyminerZ ArnyminerZ self-assigned this Jul 20, 2024
@ArnyminerZ ArnyminerZ requested a review from sunkup July 20, 2024 08:54
@ArnyminerZ ArnyminerZ added the refactoring Internal improvement of existing functions label Jul 20, 2024
@ArnyminerZ ArnyminerZ marked this pull request as ready for review July 20, 2024 08:54
@ArnyminerZ
Merge branch 'refs/heads/main-ose' into 876-syncmanager-log-last-sync…
5288f89 
…-time-directly-to-db-collection

# Conflicts:
#	app/src/main/kotlin/at/bitfire/davdroid/sync/SyncManager.kt
@ArnyminerZ
Fixed imports
d4ce9f4 
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
sunkup
sunkup requested changes Jul 22, 2024
View reviewed changes
Copy link
Member

@sunkup sunkup left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing :/

ArnyminerZ and others added 3 commits July 24, 2024 08:04
@ArnyminerZ
Fix tests
318dfa6 
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@ArnyminerZ
Merge branch 'refs/heads/main-ose' into 876-syncmanager-log-last-sync…
d995f89 
…-time-directly-to-db-collection
@rfc2822
Merge branch 'main-ose' into 876-syncmanager-log-last-sync-time-direc…
20e847e 
…tly-to-db-collection
@ArnyminerZ ArnyminerZ requested a review from sunkup July 31, 2024 13:16
@ArnyminerZ
Copy link
Member Author

@sunkup fixed :)

sunkup
sunkup requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why check whether the collection belongs to the account?
When could it not match and if it doesn't, why can't we fix it instead of doing this check here?

@rfc2822 rfc2822 requested a review from sunkup August 5, 2024 15:21
@rfc2822 rfc2822 merged commit 410c70a into main-ose Aug 5, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 876-syncmanager-log-last-sync-time-directly-to-db-collection branch August 5, 2024 15:24
@rfc2822 rfc2822 changed the title Passing collection directly SyncManager: pass collection directly Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunkup sunkup Awaiting requested review from sunkup

Assignees

@ArnyminerZ ArnyminerZ

Labels
refactoring Internal improvement of existing functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SyncManager: log last sync time directly to DB collection
3 participants
@ArnyminerZ @sunkup @rfc2822