Use DI for AccountSettings and Android tests #911
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AccountSettings
.Findings:
@Before
methods in JUnit tests, so we should only have one@Before fun setup()
per test class. This setup method runsAndroidHiltRule.inject()
first and can then initialize other things. Test variables that depend on theContext
need to be declaredby lazy
because theContext
will only be available after the Hilt rule is run.@HiltAndroidTest
), we should always inject the application context instead of getting it from the instrumentation. Otherwise Hilt may have stored another (wrapped or whatever) Application as application context and then things likeEntryPointAccessors.fromApplication
won't work properly.@ApplicationContext val context: Context
instead of anApplication
for the same reason.