Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced "Create" by "Add" when creating accounts #892

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Replaced "Create" by "Add" when creating accounts #892

merged 1 commit into from
Jul 8, 2024

Conversation

ArnyminerZ
Copy link
Member

Purpose

"Create account" could be interpreted as that it would create the account on the server.

Short description

  • Replaced "Create cccount" by "Add account"
  • Replaced "Account could not be added" by "Account could not be created"

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@ArnyminerZ
Replaced "Create" by "Add" when creating accounts
753afc9 
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ added the refactoring Internal improvement of existing functions label Jul 8, 2024
@ArnyminerZ ArnyminerZ self-assigned this Jul 8, 2024
@ArnyminerZ ArnyminerZ linked an issue Jul 8, 2024 that may be closed by this pull request
Wording: use "Add account" instead of "Create account" #888
Closed
@ArnyminerZ ArnyminerZ requested a review from rfc2822 July 8, 2024 06:41
@ArnyminerZ ArnyminerZ marked this pull request as ready for review July 8, 2024 06:41
@ArnyminerZ ArnyminerZ mentioned this pull request Jul 8, 2024
Closed
rfc2822
rfc2822 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@rfc2822 rfc2822 merged commit c02bf94 into main-ose Jul 8, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 888-wording-use-add-account-instead-of-create-account branch July 8, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfc2822 rfc2822 rfc2822 approved these changes

Assignees

@ArnyminerZ ArnyminerZ

Labels
refactoring Internal improvement of existing functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wording: use "Add account" instead of "Create account"
2 participants
@ArnyminerZ @rfc2822