Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract RefreshCollectionsWorker; move some (HomeSet)Dao calls to repository #845

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Extract RefreshCollectionsWorker; move some (HomeSet)Dao calls to repository #845

merged 3 commits into from
Jun 10, 2024

Conversation

rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Jun 10, 2024 •
edited
Loading

Purpose

  • RefreshCollectionsWorker is extracted from the inner class for better possibilities of DI and testing.
  • HomeSetDao calls are moved to DavHomeSetRepository for better app architecture

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@rfc2822 rfc2822 mentioned this pull request Jun 10, 2024
Merged
4 tasks
@rfc2822 rfc2822 force-pushed the homeset-repository branch from a3f8549 to 3613a29 Compare June 10, 2024 07:57
@rfc2822 rfc2822 self-assigned this Jun 10, 2024
@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Jun 10, 2024
@rfc2822 rfc2822 marked this pull request as ready for review June 10, 2024 08:22
@rfc2822 rfc2822 requested a review from sunkup June 10, 2024 08:22
sunkup
sunkup approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See minor comment. Looks good otherwise 👍

I will merge this directly into #829 now

app/src/main/kotlin/at/bitfire/davdroid/servicedetection/RefreshCollectionsWorker.kt Outdated Show resolved Hide resolved
@rfc2822 rfc2822 merged commit b475666 into main-ose Jun 10, 2024
5 checks passed
@rfc2822 rfc2822 deleted the homeset-repository branch June 10, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunkup sunkup sunkup approved these changes

Assignees

@rfc2822 rfc2822

Labels
refactoring Internal improvement of existing functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfc2822 @sunkup