Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Google] Allow login with custom domains again #833

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

ArnyminerZ
Copy link
Member

The PR should be in Draft state during development. As soon as it's finished, it should be marked as Ready for review and a reviewer should be chosen.

See also: Writing A Great Pull Request Description

Purpose

Allows introducing non-gmail accounts in the Google account creation screen.

Short description

Replaces the suffixation with a simple check that will add @gmail.com if the introduced email doesn't have any hostname (aka doesn't contain @).

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ linked an issue Jun 7, 2024 that may be closed by this pull request
@ArnyminerZ ArnyminerZ self-assigned this Jun 7, 2024
@ArnyminerZ ArnyminerZ added the bug Something isn't working label Jun 7, 2024
@ArnyminerZ ArnyminerZ marked this pull request as ready for review June 7, 2024 07:43
@ArnyminerZ ArnyminerZ requested a review from rfc2822 June 7, 2024 07:43
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this should do it

@rfc2822 rfc2822 merged commit ffefd51 into main-ose Jun 7, 2024
7 checks passed
@rfc2822 rfc2822 deleted the 831-google-allow-login-with-custom-domains-again branch June 7, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Google] Allow login with custom domains again
2 participants