Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite WifiPermissionsActivity to M3 #791

Merged
merged 5 commits into from
May 15, 2024
Merged

Rewrite WifiPermissionsActivity to M3 #791

merged 5 commits into from
May 15, 2024

Conversation

sunkup
Copy link
Member

@sunkup sunkup commented May 15, 2024 •
edited
Loading

Purpose

M3 is the future. Also, we want those dynamic colors.

Short description

  • Extracted composables
  • Extracted view model
  • Use m3 composables instead of M2

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup sunkup added enhancement New feature or request refactoring Internal improvement of existing functions labels May 15, 2024
@sunkup sunkup self-assigned this May 15, 2024
@sunkup sunkup requested a review from rfc2822 May 15, 2024 14:31
@sunkup sunkup changed the title Rewrite WifiPermissionsActivity to m3 Rewrite WifiPermissionsActivity to M3 May 15, 2024
rfc2822
rfc2822 approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fine 👍🏻

I have removed the stateIn because we can collect the flow directly from the Composable.

@rfc2822 rfc2822 merged commit 814d19e into main-ose May 15, 2024
7 checks passed
@rfc2822 rfc2822 deleted the rewrite-wifipermissionsactivity-to-m3 branch May 15, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfc2822 rfc2822 rfc2822 approved these changes

Assignees

@sunkup sunkup

Labels
enhancement New feature or request refactoring Internal improvement of existing functions
Projects
DAVx⁵ Releases
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunkup @rfc2822