Show Pending state in AccountsActivity, too; remove obsolete code #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rfc2822
commented
Mar 26, 2024
•
rfc2822
commented
- Show Pending sync in AccountsActivity like in AccountActivity (as UI feedback when a sync has been enqueued)
- remove obsolete code that previously gave this feedback over a Snackbar
sunkup
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
The CALDAV tab does not show the indicator bar. Neither for sync nor pending sync. Seems to have been like that before these changes as well. I will create a new issue for that.
Otherwise it works and the code looks alright to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.