Rewrite PermissionsActivity, PermissionsFragment to Compose

[ArnyminerZ]

No description provided.

[rfc2822]

Looks basically good but what I'm missing is the on/off status text for every permission. I think they're necessary because they contain recommendations and users can't know what for instance Keep permissions means.

I also wonder whether there's a better method to be notified when auto-revoke permissions is changed, other than onResume(). But I couldn't find anything else …

I have also done a few minor changes (see commit).

[ArnyminerZ]

I also wonder whether there's a better method to be notified when auto-revoke permissions is changed

I've also been searching for something, and it doesn't seem to be much. The only thing I've found is maybe using the REQUEST_IGNORE_BATTERY_OPTIMIZATIONS permission, but it seems to only be intended to be used by system apps.

[rfc2822]

@ArnyminerZ Can you add the on/off text? We can merge it then I think

[rfc2822]

Ok there's still a problem. In the old version we had a TasksWatcher, which updates the permission rows when a tasks app is (un)installed.

The current accompanist permissions approach doesn't update the rows = re-evaluate these lines:

    val openTasksAvailable = pm.resolveContentProvider(ProviderName.OpenTasks.authority, 0) != null
    val tasksOrgAvailable = pm.resolveContentProvider(ProviderName.TasksOrg.authority, 0) != null
    val jtxAvailable = pm.resolveContentProvider(ProviderName.JtxBoard.authority, 0) != null

when a tasks app is (un)installed.

Steps to reproduce:

1. Open PermissionsActivity
2. Switch to Play Store, install jtx Board, let it install in background
3. While it's installing, switch back to PermissionsActivity
4. PermissionsActivity is not updated when app is installed (jtx Board row doesn't appear)

Expected: the row should appear as soon as the app is installed.

Maybe re-evaluating the code could be triggered by a LiveData value from the model (something like "List" which is driven by the TasksWatcher)?

[ArnyminerZ]

I think this should work fine.

[rfc2822]

Thanks, looks good now!