Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccountSettings: one class per migration, tests #1181

Merged
merged 6 commits into from
Dec 20, 2024

Conversation

rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Dec 19, 2024

PR #1181 aims to refactor the AccountSettings class by splitting each migration into its own class and adding corresponding tests. The purpose is to improve maintainability and testability by isolating migration logic and ensuring each migration can be tested independently. This is achieved by:

  • Creating individual migration classes
  • Updating the AccountSettings class to use these new migration classes.
  • Adding tests for the latest migration to show how it's done for future migrations.

@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Dec 19, 2024
@rfc2822 rfc2822 self-assigned this Dec 19, 2024
@rfc2822 rfc2822 linked an issue Dec 19, 2024 that may be closed by this pull request
@rfc2822 rfc2822 changed the title AccountSettings: one class per migration, tests AccountSettings: one class per migration, tests Dec 19, 2024
@rfc2822 rfc2822 marked this pull request as ready for review December 20, 2024 10:26
@rfc2822 rfc2822 force-pushed the 1178-add-test-framework-for-accountsettings branch from b13952a to 751b8d1 Compare December 20, 2024 10:34
@rfc2822 rfc2822 merged commit 5890b3c into main-ose Dec 20, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 1178-add-test-framework-for-accountsettings branch December 20, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test framework for AccountSettings
1 participant