Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed padding problems with Edge-To-Edge #1171

Merged
merged 2 commits into from
Dec 15, 2024
Merged

Fixed padding problems with Edge-To-Edge #1171

merged 2 commits into from
Dec 15, 2024

Conversation

ArnyminerZ
Copy link
Member

Purpose

Solves #1166 and #1170

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@ArnyminerZ
Added navigation bars paddign
80e2424 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Only consuming top padding
d7c1eec 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ added the bug Something isn't working label Dec 13, 2024
@ArnyminerZ ArnyminerZ self-assigned this Dec 13, 2024
@ArnyminerZ ArnyminerZ linked an issue Dec 13, 2024 that may be closed by this pull request
Last entry in navigation drawer is obscured / can't be pressed #1170
Closed
2 tasks
@ArnyminerZ ArnyminerZ marked this pull request as ready for review December 13, 2024 10:53
@ArnyminerZ ArnyminerZ requested a review from rfc2822 December 13, 2024 10:53
rfc2822
rfc2822 approved these changes Dec 15, 2024
View reviewed changes
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct 👍🏻

@rfc2822 rfc2822 merged commit d892dd2 into main-ose Dec 15, 2024
8 checks passed
@ArnyminerZ ArnyminerZ linked an issue Dec 15, 2024 that may be closed by this pull request
Bottom bar when creating an account is oddly spaced #1166
Closed
2 tasks
@rfc2822 rfc2822 deleted the 1166-bottom-bar-when-creating-an-account-is-oddly-spaced branch December 15, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfc2822 rfc2822 rfc2822 approved these changes

Assignees

@ArnyminerZ ArnyminerZ

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@ArnyminerZ @rfc2822