LocalAddressBookStore: return all address books, including orphaned ones #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Is there any way to reproduce? Code looks good, but just to be sure 😅 |
Yes, see here: #1163 (comment) |
rfc2822
force-pushed
the
1163-orphaned-accounts-are-no-longer-cleaned-up
branch
from
6bc7238 to
6b85558
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
LocalAddressBookStore.getAll()previously didn't return all address books, but only those that are mapped to a known ID from the database.However
Syncerneeds a list of all local collections. It then deletes the ones that don't have a corresponding remote collection = database entry inCollections.Short description
LocalAddressBookStore.getAll()now returns als address booksLocalDataStore.getAll(): updated KDoc to make it clear that all entries must be returnedChecklist