Avoid very long log lines and resulting OOM #1073
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Sometimes data like a vCard with a big (16 MB) photo causes very long log lines (as in: 40 MB string), which may cause out-of-memory conditions.
Depends on bitfireAT/vcard4android#46
Short description
This PR tries to avoid long log lines on two layers:
Contact.toString()
size if there are big photos or long notes or unknown properties.PlainTextFormatter
now has some truncation logic to avoid far too long log lines.Checklist