Fixed surface container color

[ArnyminerZ]

Purpose

Surface container color was light in dark theme.

Short description

Replaced the color with a dark one.

Checklist

• The PR has a proper title, description and label.
• I have self-reviewed the PR.
• I have added documentation to complex functions and functions that can be used by other modules.
• I have added reasonable tests or consciously decided to not add tests.

[rfc2822]

@devvv4ever Did you say there is a theming problem in the light theme, too?

[devvv4ever]

yes, I think so. Something is looking different, like that there would too less contrast between bg and cards or so. can you make ss in emulator from 4.3.2 and 4.3.3 and compare?

[ArnyminerZ]

Yup, they are different.

master

4.4.2

[rfc2822]

Maybe because of the latest Compose update?

Since 4.4.2, we updated from

compose-bom = "2024.06.00"

to

compose-bom = "2024.09.03"

[rfc2822]

So the question is: What do we have to do to get the contrast back?

[ArnyminerZ]

Maybe because of the latest Compose update?

BOM 2024.06.00 is using M3 1.2.1, and 2024.09.03 M3 1.3.0.

There's only one version change between them (changelog), and they have this "DropdownMenu now supports custom color, shape, elevation, and border". So probably the change comes from there.

[rfc2822]

Or because of

SurfaceContainer variants are now used by components. Components which formally calculated color with Surface and TonalElevation now use SurfaceContainer roles by default, which are not affected by tonal elevation. (b/304584161)

Surface and Surface container baseline roles have been slightly adjusted, providing more tint in light and dark themes. (I677a5)

[ArnyminerZ]

That could also be the case. Then the question is whether we want to force the old "tinted" color, or use the new one.

[rfc2822]

That could also be the case. Then the question is whether we want to force the old "tinted" color, or use the new one.

I think just the contrast for the Cards should be better, right @devvv4ever ? Or are there other things that you have noticed? We should scan through the whole app and see if there are problems with contrast.

And of course everything for light + dark mode I guess.

[rfc2822]

Should be fine now.

[sunkup]

Good. Now it works again 👍