Fix old address book accounts not being deleted #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccount for address book account
|
This PR/issue depends on: |
1 similar comment
|
This PR/issue depends on: |
4 tasks
sunkup
force-pushed
the
1037-crashes-after-updating-to-443-beta1
branch
from
e64acf0 to
e95e58e
Compare
ArnyminerZ
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Looks good to me, let's see if @rfc2822 has anything to say
rfc2822
requested changes
Oct 7, 2024
app/src/main/kotlin/at/bitfire/davdroid/repository/AccountRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/repository/AccountRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/repository/AccountRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/repository/AccountRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/repository/AccountRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/settings/AccountSettingsMigrations.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/settings/AccountSettingsMigrations.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/settings/AccountSettingsMigrations.kt
Outdated
Show resolved
Hide resolved
sunkup
force-pushed
the
1037-crashes-after-updating-to-443-beta1
branch
from
38a6042 to
c25b2d9
Compare
sunkup
force-pushed
the
1037-crashes-after-updating-to-443-beta1
branch
from
c25b2d9 to
6616c57
Compare
rfc2822
force-pushed
the
1037-crashes-after-updating-to-443-beta1
branch
from
b3f8077 to
f4a857e
Compare
rfc2822
approved these changes
Oct 9, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1047 so that the migration is not run in main thread
Purpose
#989 has renamed address book accounts. The introduced migration creates new address books and fails at deleting the old ones. Now old orphan ones are lying around and even caused exceptions.
An exception should not have been thrown. We should simply log a warning instead.
Orphaned address book accounts should of course not exist in the first place and be deleted by the AccountsCleanupWorker in case they do exist.
In the migration: Instead of syncing to create new address book accounts and then deleting the old ones with the AccountsCleanupworker we should actually rename the existing address book accounts before a first sync happens in the account settings migration.
Short description
AccountsCleanupWorker(was not working)Checklist