Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved pull-to-refresh indicator below tabs #1028

Merged

Conversation

ArnyminerZ
Copy link
Member

Purpose

The pull to refresh indicator appears on top of the tabs in the collection list, which makes the UI look a bit cursed.

Short description

Moved the indicator below the tabs.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ added the enhancement New feature or request label Sep 16, 2024
@ArnyminerZ ArnyminerZ self-assigned this Sep 16, 2024
@ArnyminerZ ArnyminerZ linked an issue Sep 16, 2024 that may be closed by this pull request
2 tasks
@ArnyminerZ ArnyminerZ marked this pull request as ready for review September 16, 2024 13:02
@rfc2822
Copy link
Member

rfc2822 commented Sep 16, 2024

Thanks, let's see what @sunkup says :)

@rfc2822 rfc2822 requested review from sunkup September 16, 2024 13:07
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only moved the PullToRefreshBox, right?

Looks okay to me. And works :)

@rfc2822
Copy link
Member

rfc2822 commented Sep 16, 2024

You only moved the PullToRefreshBox, right?

Did you use the "Hide whitespace" feature of Github when viewing the changes? I really find it useful for things like this

@rfc2822 rfc2822 merged commit 5180b99 into main-ose Sep 16, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 1020-pull-to-refresh-indicator-appears-on-top-of-tabs branch September 16, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull to refresh indicator appears on top of tabs
3 participants