Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added isLoading to Assistant #1027

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Added isLoading to Assistant #1027

merged 1 commit into from
Sep 16, 2024

Conversation

ArnyminerZ
Copy link
Member

Purpose

Add isLoading to Assistant. If true shows a horizontal loading indicator.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@ArnyminerZ
Added isLoading to Assistant
1b84a15 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ added the enhancement New feature or request label Sep 16, 2024
@ArnyminerZ ArnyminerZ self-assigned this Sep 16, 2024
@ArnyminerZ ArnyminerZ linked an issue Sep 16, 2024 that may be closed by this pull request
Add account: progress bar padding on the last step #1025
Closed
2 tasks
@ArnyminerZ ArnyminerZ marked this pull request as ready for review September 16, 2024 11:48
@ArnyminerZ ArnyminerZ requested a review from sunkup September 16, 2024 11:48
sunkup
sunkup approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@sunkup sunkup left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I actually might have liked it more with the padding, but I can see that we want it to be consistent.

Looks good 👍

@rfc2822 rfc2822 merged commit 111481c into main-ose Sep 16, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 1025-add-account-progress-bar-padding-on-the-last-step branch September 16, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunkup sunkup sunkup approved these changes

Assignees

@ArnyminerZ ArnyminerZ

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add account: progress bar padding on the last step
3 participants
@ArnyminerZ @sunkup @rfc2822