Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword login text #1026

Merged

Conversation

rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Sep 16, 2024

Purpose

It was not clear what "Add account" does, especially that it doesn't just sign in to an app-proprietary hosted account like for 99.9% of the apps. This was also the reason that Google had sometimes rejected the app because they didn't "get a test account on our server".

We

  • split Welcome and the welcome text for easier translations,
  • make it clear that it's about a user server → empty accounts text, privacy note
  • decided to keep the words
    • Add account for the whole process of adding an account and
    • Login for the first step of this process
  • changed the last button to Finish to distinguish between the title of the whole process (Add account) and the specific step.

Short description

  • Change empty accounts text
  • Add privacy note to Login screen
  • Changed last button text

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

- Change empty accounts text
- Add privacy note to Login screen
- Changed last button text
@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Sep 16, 2024
@rfc2822 rfc2822 self-assigned this Sep 16, 2024
@rfc2822 rfc2822 linked an issue Sep 16, 2024 that may be closed by this pull request
@rfc2822 rfc2822 marked this pull request as ready for review September 16, 2024 11:40
@rfc2822 rfc2822 requested a review from sunkup September 16, 2024 11:40
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍

@rfc2822 rfc2822 merged commit 4dc7df7 into main-ose Sep 16, 2024
14 checks passed
@rfc2822 rfc2822 deleted the 1008-rename-add-account-to-something-more-understandable branch September 16, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "Add Account" to something more understandable
2 participants