Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClickableText for URLs has been deprecated #1024

Merged
merged 8 commits into from
Sep 16, 2024
Merged

ClickableText for URLs has been deprecated #1024

merged 8 commits into from
Sep 16, 2024

Conversation

ArnyminerZ
Copy link
Member

@ArnyminerZ ArnyminerZ commented Sep 16, 2024 •
edited
Loading

Purpose

Fix all deprecations regarding ClickableText and URLs.

Short description

  • Fixed deprecations in UiUtils.
  • ClickableTextWithLink will now do the same as Text
  • Replaced the default style of ClickableTextWithLink with LocalTextStyle

Important

We should look whether managed uses it before releasing. Merge and then check in managed.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@ArnyminerZ
Got rid of UrlAnnotation
bca0a29 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Deprecated and suggested a ReplaceWith
f1ab015 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Optimized imports
0e5af0f 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ added the refactoring Internal improvement of existing functions label Sep 16, 2024
@ArnyminerZ ArnyminerZ self-assigned this Sep 16, 2024
@ArnyminerZ ArnyminerZ linked an issue Sep 16, 2024 that may be closed by this pull request
ClickableText deprecated #1023
Closed
1 task
@ArnyminerZ
Replaced usages of ClickableTextWithLink
fd263ec 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Removed ClickableTextWithLink
8628aac 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ marked this pull request as ready for review September 16, 2024 11:53
@ArnyminerZ ArnyminerZ requested a review from rfc2822 September 16, 2024 11:53
@rfc2822 rfc2822 requested review from sunkup and removed request for rfc2822 September 16, 2024 12:34
sunkup
sunkup approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some experimental text api annotations left, which I removed. :)

@rfc2822 rfc2822 merged commit dcb7e31 into main-ose Sep 16, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 1023-clickabletext-deprecated branch September 16, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunkup sunkup sunkup approved these changes

Assignees

@ArnyminerZ ArnyminerZ

Labels
refactoring Internal improvement of existing functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClickableText deprecated
3 participants
@ArnyminerZ @sunkup @rfc2822