Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase SDK level to 35 #1003

Merged
merged 9 commits into from
Sep 10, 2024
Merged

Increase SDK level to 35 #1003

merged 9 commits into from
Sep 10, 2024

Conversation

ArnyminerZ
Copy link
Member

@ArnyminerZ ArnyminerZ commented Sep 4, 2024 •
edited
Loading

Purpose

Increase target SDK level to 35 in order to support Android 15.

Short description

See #997.

I've also had to modify some functions since it seems that some functions now return null. See changes, I've made them as simple as possible.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@ArnyminerZ
Increase SDK level
4fd3d02 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ added the refactoring Internal improvement of existing functions label Sep 4, 2024
@ArnyminerZ ArnyminerZ self-assigned this Sep 4, 2024
@ArnyminerZ ArnyminerZ linked an issue Sep 4, 2024 that may be closed by this pull request
Target Android 15 (API 35) #997
Closed
1 task
@ArnyminerZ
Fixed nullability issues
4f56046 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ marked this pull request as ready for review September 6, 2024 07:23
@ArnyminerZ ArnyminerZ requested a review from sunkup September 6, 2024 07:23
@ArnyminerZ @rfc2822
Increase SDK level
0582587 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ @rfc2822
Fixed nullability issues
ed7a47d 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@rfc2822 rfc2822 force-pushed the 997-target-android-15-api-35 branch from 4f56046 to ed7a47d Compare September 6, 2024 09:21
@rfc2822
Copy link
Member

rfc2822 commented Sep 6, 2024

@ArnyminerZ There's some "new API" problem in the existing DiskCache about removeFirst. Maybe that can be done with a Kotlin stdlib (or Guava) call.

@ArnyminerZ
Copy link
Member Author

ArnyminerZ commented Sep 6, 2024 •
edited
Loading

@rfc2822 done

I just replaced removeFirst by removeAt(0). I don't know why

sunkup
sunkup approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@ArnyminerZ
Switched to null check instead of NPE catch
fc150e5 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Using orEmpty
9a7cfb1 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ requested a review from rfc2822 September 10, 2024 09:10
rfc2822
rfc2822 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks :)

@rfc2822 rfc2822 merged commit 0581417 into main-ose Sep 10, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 997-target-android-15-api-35 branch September 10, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunkup sunkup sunkup approved these changes

@rfc2822 rfc2822 rfc2822 approved these changes

Assignees

@ArnyminerZ ArnyminerZ

Labels
refactoring Internal improvement of existing functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Target Android 15 (API 35)
3 participants
@ArnyminerZ @rfc2822 @sunkup