Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint fails in AboutActivity #1001

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

ArnyminerZ
Copy link
Member

Purpose

lint fails with:

 /home/runner/work/davx5-ose/davx5-ose/app/src/main/kotlin/at/bitfire/davdroid/ui/AboutActivity.kt: Error: Unexpected failure during lint analysis of AboutActivity.kt (this is a bug in lint or one of the libraries it depends on)

https://github.com/bitfireAT/davx5-ose/actions/runs/10698537347/job/29663348020

Short description

It looks like a bug in lint directly, it's crashing in AboutActivity, but for example, in ICSx5 fails in EnterUrlComposable (see). I think it all comes from the same place. I couldn't find anything on Google, but I guess it's related to Compose, maybe it will get fixed in a future version.

I've disabled CoroutineCreationDuringComposition, which of course doesn't solve anything, but at least compiles correctly.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ linked an issue Sep 4, 2024 that may be closed by this pull request
@ArnyminerZ ArnyminerZ self-assigned this Sep 4, 2024
@ArnyminerZ ArnyminerZ marked this pull request as ready for review September 4, 2024 12:50
@ArnyminerZ ArnyminerZ requested a review from rfc2822 September 4, 2024 12:50
@rfc2822
Copy link
Member

rfc2822 commented Sep 4, 2024

@rfc2822 rfc2822 added bug Something isn't working 3rd party related to a third-party product (library, …) labels Sep 4, 2024
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's disable the warning because it's a bug in lint.

However, we should do so in a separate line and add a note to remove it with the next Compose version (maybe we can include the current bom version where this happens). Also with link to https://issuetracker.google.com/issues/298483892

Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ requested a review from rfc2822 September 4, 2024 15:25
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super :)

@rfc2822 rfc2822 merged commit fc69804 into main-ose Sep 4, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 1000-lint-fails-in-aboutactivity branch September 4, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party related to a third-party product (library, …) bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lint fails in AboutActivity
2 participants