Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose logging setting: wrong initial value #821

Closed
rfc2822 opened this issue May 29, 2024 Discussed in #820 · 0 comments · Fixed by #822
Closed

Verbose logging setting: wrong initial value #821

rfc2822 opened this issue May 29, 2024 Discussed in #820 · 0 comments · Fixed by #822
Assignees
Labels
bug Something isn't working

Comments

@rfc2822
Copy link
Member

rfc2822 commented May 29, 2024

When verbose logging is active and you enter the app settings, the switch for "verbose logging" is unchecked (should be checked) and can't be toggled.

Reason: PreferenceRepository.observeAsFlow doesn't emit an initial value, so the switch is unchecked although verbose logging is actually enabled. Toggling will then do the opposite of what it should do (enable verbose logging although it's already enabled instead of turning it off), so the switch just doesn't work.


Discussed in #820

Originally posted by exstntlmsnthrp May 29, 2024
I just installed the newly released version 4.4-ose from here on GitHub. Within the app, the verbose debugging switch is toggled off and disabled and I am unable to change the setting. I'd been leaving it enabled because of the previous small parcel bug that was fixed.

Screenshot_20240529-132404.png

However, I get a notification that verbose logging is enabled.

Screenshot_20240529-132421.png

Is it enabled or disabled? Can the toggle switch get fixed?

Cheers for all your brilliant work on a great app.

@rfc2822 rfc2822 added the bug Something isn't working label May 29, 2024
@rfc2822 rfc2822 self-assigned this May 29, 2024
@rfc2822 rfc2822 linked a pull request May 29, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Todo to Done in DAVx⁵ Releases May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant