Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreferenceRepository.observeAsFlow: emit initial value #822

Merged
merged 1 commit into from
May 30, 2024

Conversation

rfc2822
Copy link
Member

@rfc2822 rfc2822 commented May 29, 2024

PreferenceRepository.observeAsFlow didn't emit an initial value (only observe updates). This causes the "Verbose logging" UI switch to be unchecked when the App Settings are opened even if verbose logging is actually enabled.

Fix: emit initial value

@rfc2822 rfc2822 added the bug Something isn't working label May 29, 2024
@rfc2822 rfc2822 requested a review from sunkup May 29, 2024 22:19
@rfc2822 rfc2822 self-assigned this May 29, 2024
@rfc2822 rfc2822 linked an issue May 29, 2024 that may be closed by this pull request
@rfc2822 rfc2822 marked this pull request as ready for review May 29, 2024 22:20
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍

@rfc2822 rfc2822 merged commit 671c173 into main-ose May 30, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 821-verbose-logging-setting-wrong-initial-value branch May 30, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verbose logging setting: wrong initial value
2 participants