Multiplatform support #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched from okhttp3 to ktor Switched from junit to kotest Switched from xmlpp to xmlutil Added klock for time/date management Removed BasicDigestAuth, can be done using ktor with two authenticators Reworked tests to use ktor-mock-client and kotest followRedirect was removed, will need to be investigated if this can be done using the Ktor provided HttpRedirect plugin of if a custom one is necessary
- Fixed Exception initialization by moving from a constructor into a suspend operator fun - Moved XMLWriter&XMLReader creation into XMLUtils for more control - Use HttpClient.prepareRequest to allow for multiple reads - Fixed MockClient usage in DavCollectionTest - Fixed DavExceptioTests - Improved request construction in DavResource - Fixed headers in DavResourceTest.testOptions - Use XmlUtils.processTag as a centralized function to walk xml - Fixed an issue where Response.isSuccess was returning false when the Response was actually successful - Fixed StatusLine parsing - Fixed UrlUtils.equals - Improved UrlUtilsTest to be data driven - Fixed XML Traversal to conform to the new XmlReader (depth was handled differently)
Not quite the same as the old implementation, but it's valid xml
Initial support for redirect follow - This will need some work, since it currently relies on the HttpRedirect plugin to be configured to allow redirect on all methods Improved XmlUtils.processTag
Fixed an issue with multistatus tests
|
|
…viour Add missing header to DavCollection.post Fix an issue where the namespace was missing for a prefix when using the generic XMLWriter Fixed an issue reading text when using the generic XMLReader
|
Wow, such a big PR, it will surely take a while to review. In the meantime, please, make sure all tests are passing |
|
Unfortunately these changes are currently not in the DAVx5 scope and we primarly use dav4jvm for DAVx5. Thanks for the PR and I encourage you to keep the fork up to date, but at the moment we can't merge this. |
|
I just wanted to let you know that I would also be interested in the multiplatform support for my current pet project. Thx bitfire for your work! 👏 I own all the DAVx⁵ badges. ❤️ And thx @McDjuady for your effort and the fork, I will check it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to convert the library to multiplatform, since I needed it for a project of mine.
So far I only tested the JVM variant, but adding other versions shouldn't be too difficult, since all libraries are multiplatform libraries themselves.
Major changes include:
I don't know if you even want this library to be a multiplatform library, so if not just let me know and I'll keep the fork to myself :)
Otherwise I'd be very happy for feedback on the changes.
Cheers
Max