Repository navigation
fix(ui): generalize action failure banner - #208
Merged
Merged
Conversation
Split `start`/`stop` out of the up/down aliases into first-class
lifecycle commands that sit between pause/resume and down/up:
- `localnet stop` → docker compose stop (containers kept on disk)
- `localnet start` → docker compose start, falling back to a full
`up` (reusing the recorded version + profiles) when the containers
were already removed or the instance isn't registered
- `unpause` added as an alias of `resume`
Full CLI ↔ Web UI parity: the instance detail card gains Stop and
Start actions (and a distinct Down button), backed by new
/stop (sync 204) and /start (204 fast / 202 up-fallback) handlers.
Docker layer gains `-p`-only StopContainers/Start; shared logic lives
in internal/localnet/stopstart.go. Reconciler now preserves the
stopped status when no container is running.
Docs updated: pause-vs-stop-vs-down comparison table + guidance in the
lifecycle guide, corrected alias claims + new verbs in the agent skill
doc, and a new stop/start section in changes-from-proposal.
BEHAVIOUR CHANGE: `localnet stop` no longer removes containers (was an
alias for `down`) and `localnet start` no longer unconditionally
recreates the stack (was an alias for `up`); it converges to running,
recreating only when containers are gone. Use `down`/`up` explicitly
for the old behaviour.
Split `start`/`stop` out of the up/down aliases into first-class
lifecycle commands that sit between pause/resume and down/up:
- `localnet stop` → docker compose stop (containers kept on disk)
- `localnet start` → docker compose start, falling back to a full
`up` (reusing the recorded version + profiles) when the containers
were already removed or the instance isn't registered
- `unpause` added as an alias of `resume`
Full CLI ↔ Web UI parity: the instance detail card gains Stop and
Start actions (and a distinct Down button), backed by new
/stop (sync 204) and /start (204 fast / 202 up-fallback) handlers.
Docker layer gains `-p`-only StopContainers/Start; shared logic lives
in internal/localnet/stopstart.go. Reconciler now preserves the
stopped status when no container is running.
Docs updated: pause-vs-stop-vs-down comparison table + guidance in the
lifecycle guide, corrected alias claims + new verbs in the agent skill
doc, and a new stop/start section in changes-from-proposal.
BEHAVIOUR CHANGE: `localnet stop` no longer removes containers (was an
alias for `down`) and `localnet start` no longer unconditionally
recreates the stack (was an alias for `up`); it converges to running,
recreating only when containers are gone. Use `down`/`up` explicitly
for the old behaviour.
zheli
force-pushed
the
add-start-stop-unpause
branch
from
July 5, 2026 06:37
6c7a1e7 to
1725d13
Compare
…/action-error-banner
# Conflicts: # frontend/src/screens/InstanceDetail.test.tsx # internal/localnet/stopstart_test.go # internal/ui/handlers/stopstart_test.go
zheli
added a commit
that referenced
this pull request
Aug 19, 2026
* fix(ui): generalize action failure banner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the instance detail action error banner from
Stop failedto neutralAction failed, since the same state is shared by start, stop, down, pause, resume, recreate, and remove actions. Adds a regression test with a failed Start action.Testing
npm test -- InstanceDetail.test.tsxfromfrontend/Review Issue
Stop failed, even for non-stop failures.