Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add addon title from metadata #248

Merged
merged 2 commits into from
Sep 30, 2024
Merged

add addon title from metadata #248

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3401e94
add addon title from metadata
Andserbanbitdefender Sep 30, 2024
eb3ce3b
lint
Andserbanbitdefender Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add addon title from metadata
  • Loading branch information
@Andserbanbitdefender
Andserbanbitdefender committed Sep 30, 2024
commit 3401e9426d31a7d13df5b039c47b9a02531a4aee
1 change: 1 addition & 0 deletions _src/blocks/new-prod-boxes/new-prod-boxes.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@
font-family: Arial, sans-serif;
margin-top: 0;
margin-bottom: 4px;
width: 80%
}

.new-prod-boxes-container .new-prod-boxes .prod_box .inner_prod_box h4 a {
Expand Down
4 changes: 2 additions & 2 deletions _src/blocks/new-prod-boxes/new-prod-boxes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@
const {
// eslint-disable-next-line no-unused-vars
products, familyProducts, monthlyProducts, priceType, pid, mainProduct,
addOnProducts, addOnMonthlyProducts, type, hideDecimals, thirdRadioButtonProducts, saveText,
addOnProducts, addOnMonthlyProducts, type, hideDecimals, thirdRadioButtonProducts, saveText, addonProductName

Check failure on line 209 in _src/blocks/new-prod-boxes/new-prod-boxes.js

View workflow job for this annotation

GitHub Actions / linting 

Missing trailing comma
} = block.closest('.section').dataset;
// if options exists, this means the component is being called from aem
if (options) {
Expand Down Expand Up @@ -472,7 +472,7 @@
<div class="add-on-product" style="display: none;">
${billed2 ? '<hr>' : ''}
${planSwitcher2.outerHTML ? planSwitcher2.outerHTML : ''}
<h4>${title.innerHTML}</h4>
<h4>${addonProductName}</h4>
<div class="hero-aem__prices__addon"></div>
</div>
</div>
Expand Down
Loading