Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data layer #203

Merged
merged 11 commits into from
Sep 6, 2024
Merged

Fix data layer #203

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ed0c00e
take 1 on fixing data layer on import
Matei-Iordache Sep 6, 2024
943e564
take 2
Matei-Iordache Sep 6, 2024
d3d70b1
take 3
Matei-Iordache Sep 6, 2024
faab138
chore: Fix import path for sendAnalyticsPageLoadedEvent in new-prod-b…
Matei-Iordache Sep 6, 2024
6121630
take 4
Matei-Iordache Sep 6, 2024
30f6e8d
take 5
Matei-Iordache Sep 6, 2024
2b29220
TAKE 6
Matei-Iordache Sep 6, 2024
002f647
Take 7
Matei-Iordache Sep 6, 2024
b61c180
Take 8
Matei-Iordache Sep 6, 2024
f5e87d3
Cleanup
Matei-Iordache Sep 6, 2024
a77345c
Modify parameter name
Matei-Iordache Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Take 7
  • Loading branch information
@Matei-Iordache
Matei-Iordache committed Sep 6, 2024
commit 002f647c2c0822acbd71d43230e2b569d7e70b33
2 changes: 1 addition & 1 deletion _src/blocks/new-prod-boxes/new-prod-boxes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ export default async function decorate(block, options) {
if (isInLandingPages) {
const { decorateIcons } = await import('../../scripts/utils/utils.js');
// eslint-disable-next-line import/no-unresolved
const { GLOBAL_EVENTS } = await import(`https://${window.location.hostname}/_src-lp/scripts/utils/utils.js`);
const { GLOBAL_EVENTS } = await import(`https://${window.location.hostname}/_src-lp/scripts/utils.js`);
const { sendAnalyticsPageLoadedEvent } = await import(`https://${window.location.hostname}/_src-lp/scripts/adobeDataLayer.js`);
decorateIcons(block.closest('.section'));

Expand Down