Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEX-19622 | added signature option to hero banner #169

Merged
merged 6 commits into from
Sep 18, 2024
Merged

DEX-19622 | added signature option to hero banner #169

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
40356c8
DEX-19622 | added signature option to hero banner
iconstantin-bd Aug 27, 2024
3a08535
DEX-19622 | fixed linting
iconstantin-bd Aug 27, 2024
75a8c3b
DEX-19622 | moved the code to make a single dataset parsing
iconstantin-bd Aug 27, 2024
40f26de
Merge branch 'main' into DEX-19622
iconstantin-bd Sep 18, 2024
adfe778
Merge branch 'main' into DEX-19622
iconstantin-bd Sep 18, 2024
136b010
fixed linting issue
iconstantin-bd Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into DEX-19622
  • Loading branch information
@iconstantin-bd
iconstantin-bd committed Sep 18, 2024
commit 40f26de5526ef5845d9b97b1eff26b2d28218203
1 change: 1 addition & 0 deletions _src/blocks/hero/hero.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ export default async function decorate(block) {
// this defines wether the modals automatically refresh or not in the hero banner
stopAutomaticModalRefresh,
signature,
label,
} = block.closest('.section').dataset;

buildHeroBlock(block);
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.