v1: Connection re-use, Streaming, … #164
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Exciting! Thanks for all your hard work on this, @pmeinhardt! Love these goals! 💯 |
pmeinhardt
force-pushed
the
v1
branch
21 times, most recently
from
b682d33 to
839c28c
Compare
|
I might drop SFTP-based uploads from the goals for the next release for reasons outlined here: #162 (comment) |
pmeinhardt
changed the title
pmeinhardt
force-pushed
the
v1
branch
2 times, most recently
from
f86f770 to
ee59934
Compare
Note that you will need to run a login shell so /etc/profile is loaded.
If you are starting the image directly, use:
docker run -it --rm sshkit-test-sshd /bin/sh -l
The "-l" flag will make `sh` behave like a login shell.
Remove `:impl` option from calls. Instead configure the module to use - implementation or mock - in the application environment.
Does not respect all the context options at the moment.
Apparently `:erl_tar.add/3` recursively adds files and subdirectories.
|
Rebased :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still very much a work in progress, but I am quite happy with how it's chugging along and eager to release once I am happy with this next iteration of the package. 🚂
The main goals for the new release are: ✨
run,uploadanddownloadfunctions all set up an SSH connection to the remote each time they are invoked. The new API encourages connecting to each remote only once and then using the connection for multiple operations.I'll post more updates here as I am making progress. Happy about feedback and questions. ✌️
Much love to all of you 💚