Skip to content

TODOs #1

@bitcoinpirate

Description

@bitcoinpirate
  • when conversation is currently visible reaction sound is not used. This is used: "recipient.messageRingtone ?: SignalStore.settings.messageNotificationSound"
  • reactions sound can only be customized globally, if chat has it's own message_channel, the message_channel will be used
  • not saved in Signalstore yet
  • only tested with Android API 34
  • private static void onUpgrade(@nonnull NotificationManager notificationManager, int oldVersion, int newVersion) is not yet implemented for reactions_channel

and one should probably implement an equivalent function

@TargetApi(26)
  private void updateMessageChannel(@NonNull ChannelUpdater updater) {
    NotificationManager notificationManager = ServiceUtil.getNotificationManager(context);
    int existingVersion                     = TextSecurePreferences.getNotificationMessagesChannelVersion(context);
    int newVersion                          = existingVersion + 1;

    Log.i(TAG, "Updating message channel from version " + existingVersion + " to " + newVersion);
    if (updateExistingChannel(notificationManager, getMessagesChannelId(existingVersion), getMessagesChannelId(newVersion), updater)) {
      TextSecurePreferences.setNotificationMessagesChannelVersion(context, newVersion);
    } else {
      onCreate(notificationManager);
    }}

for reaction channels as well

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions