-
Notifications
You must be signed in to change notification settings - Fork 137
Newsletter-204: Translate into Hindi #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
During the testing process, I could not solve the following test failure.
However, I thought it would be best to post the translation on time. This would help the community and allow me to get help from people who know this stuff better! :) |
We have a script that automatically generates an anchor link to the title of sections. Since links in HTML can only contain ASCII characters, it prunes all UTF-8 characters before generating the anchor. I suspect that either two of your section titles end up empty or with the same ASCII characters after pruning. We have been running into similar issues with the Chinese translation. You may be able to fix it by adding a comment to it: #349 (comment) |
7a522ca
to
46a5a5f
Compare
Updated from 7a522ca to 46a5a5f (pr788.01 -> pr788.02, diff) Changes:
Thanks, @xekyo, for your suggestion! I took some references from the Japanese translation of Newsletter-204 on properly incorporating the comments. So thanks to @azuchi for it! |
Adding a comment to this section would also pass the chek. |
46a5a5f
to
dd5d100
Compare
Updated from 46a5a5f to dd5d100 (pr788.02 -> pr788.03, diff) Changes:
Thanks, @azuchi, for your suggestion! I looked through the heading and decided that it would be better to translate BIP back to English instead of adding a comment for this heading. Doing this solved the building issue. I successfully built this PR locally using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you @shaavan !
This PR provides a Hindi translation of Newsletter-204