Skip to content

Newsletter-204: Translate into Hindi #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

shaavan
Copy link
Contributor

@shaavan shaavan commented Jun 16, 2022

This PR provides a Hindi translation of Newsletter-204

@shaavan
Copy link
Contributor Author

shaavan commented Jun 16, 2022

During the testing process, I could not solve the following test failure.

## Check for duplicate anchors
! find _site/ -name '*.html' | while read file ; do \
  cat $file \
  | egrep -o "(id|name)=[\"'][^\"']*[\"']" \
  | sed -E "s/^(id|name)=//; s/[\"']//g" \
  | sort | uniq -d \
  | sed "s|.*|Duplicate anchor in $file: #&|" ; \
done | grep .
Duplicate anchor in _site/hi/newsletters/2022/06/15/index.html: #ln
make: *** [Makefile:91: test-after-build] Error 1

However, I thought it would be best to post the translation on time. This would help the community and allow me to get help from people who know this stuff better! :)

@murchandamus
Copy link
Collaborator

murchandamus commented Jun 16, 2022

We have a script that automatically generates an anchor link to the title of sections. Since links in HTML can only contain ASCII characters, it prunes all UTF-8 characters before generating the anchor. I suspect that either two of your section titles end up empty or with the same ASCII characters after pruning. We have been running into similar issues with the Chinese translation.

You may be able to fix it by adding a comment to it: #349 (comment)

@shaavan shaavan force-pushed the hi-translate-204 branch from 7a522ca to 46a5a5f Compare June 19, 2022 13:22
@shaavan
Copy link
Contributor Author

shaavan commented Jun 19, 2022

Updated from 7a522ca to 46a5a5f (pr788.01 -> pr788.02, diff)

Changes:

  • Updated section headings with appropriate section comments wherever required.
  • Translated Taproot back to English, as it is a technical term.

Thanks, @xekyo, for your suggestion! I took some references from the Japanese translation of Newsletter-204 on properly incorporating the comments. So thanks to @azuchi for it!

@azuchi
Copy link
Contributor

azuchi commented Jun 20, 2022

  • निरंतर पैकेज रिले बीआईपी चर्चा: [पैकेज रिले][topic package relay] के लिए हाल ही में एक मसौदा

Adding a comment to this section would also pass the chek.

@shaavan shaavan force-pushed the hi-translate-204 branch from 46a5a5f to dd5d100 Compare June 20, 2022 08:18
@shaavan
Copy link
Contributor Author

shaavan commented Jun 20, 2022

Updated from 46a5a5f to dd5d100 (pr788.02 -> pr788.03, diff)

Changes:

  • Translated BIP and Bitcoin Improvement Proposal (BIP) back to English, as these are technical terms.

Thanks, @azuchi, for your suggestion! I looked through the heading and decided that it would be better to translate BIP back to English instead of adding a comment for this heading. Doing this solved the building issue.

I successfully built this PR locally using make production -j8.

Copy link
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you @shaavan !

@bitschmidty bitschmidty merged commit 4865d02 into bitcoinops:master Jun 20, 2022
@shaavan shaavan deleted the hi-translate-204 branch August 13, 2022 14:45
harding pushed a commit to harding/bitcoinops.github.io that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants