Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletters: add 135 (2021-02-10) #515

Merged
merged 5 commits into from
Feb 10, 2021
Merged

Newsletters: add 135 (2021-02-10) #515

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
525b92d
Newsletters: add 135 (2021-02-10)
harding Feb 8, 2021
5178259
add bitcoin core 19509
adamjonas Feb 8, 2021
f4193ab
News135: Add Rust-Lightning #744 description
dongcarl Feb 8, 2021
d778e72
News135: summarize HWI#433
murchandamus Feb 8, 2021
82e73a8
News135: Bitcoin Core Review Club feature on PR 20799
jonatack Feb 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add bitcoin core 19509
  • Loading branch information
@adamjonas @bitschmidty
adamjonas authored and bitschmidty committed Feb 10, 2021
commit 517825902f9c0b62c72f4ed96c6793bff19c618f
9 changes: 8 additions & 1 deletion _posts/en/newsletters/2021-02-10-newsletter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,13 @@ BOLTs][bolts repo].*

- [HWI #433][] trezor: Enable processing of OP_RETURN outputs FIXME:Xekyo

- [Bitcoin Core #19509][] Per-Peer Message Capture FIXME:adamjonas
- [Bitcoin Core #19509][] adds per-peer message capture between nodes as well
as the ability to produce JSON outputs from those logs. Using the newly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/produce JSON outputs from those logs/parse the dumped messages into JSON/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it better the way it is (though I'd probably not have pluralized "outputs"; if that's your concern, we could possibly just drop that word without otherwise changing the sentence).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to distinguish between logs (which I'd generally understand as a file that records specific events in the code) and what we have here, which is message dumps/message capture. It's not very important.

introduced command line argument `-capturemessages`, any message
that the node sends or receives is logged. There is a
[long history][bitcoin dissector] of tools with similar functionality,
but this addition provides a native alternative to less actively
maintained options.

- [Bitcoin Core #20764][] adds additional information to the output
produced using `bitcoin-cli -netinfo`. New details include the type
Expand Down Expand Up @@ -163,3 +169,4 @@ BOLTs][bolts repo].*
[i2p]: https://en.wikipedia.org/wiki/I2P
[news131 bech32m]: /en/newsletters/2021/01/13/#bech32m
[news130 bip322]: /en/newsletters/2021/01/06/#proposed-updates-to-generic-signmessage
[bitcoin dissector]: https://en.bitcoinwiki.org/wiki/Bitcoin_Dissector