feat(psbt): add PsbtV2 BIP-370 support built on bip370#2327
Draft
jvgelder wants to merge 1 commit into
Draft
Conversation
Adds PSBTv2 (BIP-370) support via a wrapper around bip370. Where bip370 only handles the structural side: map encoding, role enforcement and serialization. This wrapper adds signing and validation with an API similair to Psbt. What's new over the base bip370 library: - Signing and signature validation legacy, segwit, taproot key/script path - toTransaction extracts a finalized tx with a fee rate guard - verifyNonWitnessUtxo validates funding tx via Transaction.getHash() - getInputHashForSig and getTaprootHashesForSig expose the raw sighash directly for hardware wallets and HSMs that cannot hold PSBT state. Prefer signInput() or passing the PSBT as hex where possible, these helpers skip the script and pubkey checks that signInput() enforces, placing full responsibility for correctness on the caller.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds PSBTv2 (BIP-370) support via a wrapper around bip370. Where bip370 only handles the structural side: map encoding, role enforcement and serialization. This wrapper adds signing and validation with an API similair to Psbt.
What's new over the base bip370 library:
Before merge I would like someone to have a look at the bip370 implementation first (also need to fix one test) :)
closes #2316