feat: add taproot HD signing support #2299
Open
+160
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for tapBip32Derivation in HD signing methods: - signInputHD and signInputHDAsync now work with taproot inputs - inputHasHDKey and outputHasHDKey check tapBip32Derivation - New getSignersFromHDTaproot helper for taproot-specific derivation This enables signing taproot inputs using HD wallets with the standard signAllInputsHD and signInputHD methods. Fixes bitcoinjs#2000 Fixes bitcoinjs#2132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for
tapBip32Derivationin HD signing methods, enabling taproot inputs to be signed using HD wallets.Problem
Currently,
signInputHD,signInputHDAsync, andsignAllInputsHDonly checkbip32Derivationfor deriving signing keys. This means taproot inputs that usetapBip32Derivation(as specified in BIP-371) cannot be signed using these HD methods.Users have to manually iterate over inputs and handle taproot derivation separately, which defeats the purpose of the convenience HD signing methods.
Solution
getSignersFromHDto detect taproot inputs and delegate to newgetSignersFromHDTaproothelpergetSignersFromHDTaprootfunction that:tapBip32Derivationby master fingerprintinputHasHDKeyandoutputHasHDKeyto also checktapBip32DerivationChanges
ts_src/psbt.ts: Core implementation (~60 lines added)test/fixtures/psbt.json: Updated error message in test fixtureTesting
All 2660 existing tests pass. The implementation follows the same pattern as existing HD signing code but handles the x-only pubkey format used in taproot.
Fixes #2000
Fixes #2132
Contribution by Gittensor, learn more at https://gittensor.io/