Allow excluding wordlists when building for browserify #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the TS version of #98 |
d-yokoi
reviewed
Mar 26, 2019
ts_src/_wordlists.ts
Outdated
| _default = require('./wordlists/english.json'); | ||
| wordlists.english = _default as string[]; | ||
| wordlists.EN = _default as string[]; | ||
| } catch (err) {} |
There was a problem hiding this comment.
I think it would be even better if you implement this using loop.
d-yokoi
reviewed
Mar 26, 2019
| }; | ||
| export function setDefaultWordlist(language: string): void { | ||
| const result = wordlists[language]; | ||
| if (result) DEFAULT_WORDLIST = result; |
There was a problem hiding this comment.
I expect this function to throw error if the wordlist does not exist.
There was a problem hiding this comment.
In addition, why don't we provide getDefaultWordlist as well.
junderw
commented
Mar 28, 2019
| } | ||
|
|
||
| export function getDefaultWordlist(): string { | ||
| if (!DEFAULT_WORDLIST) throw new Error('No Default Wordlist set'); |
There was a problem hiding this comment.
Maybe this should just return null...?
There was a problem hiding this comment.
Why don't you export DEFAULT_LANGUAGE from _wordlists.ts and use it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help when packaging bip39 to keep file size down.
With all wordlists: 391392 bytes uglified / compressed.
With English only: 249920 bytes
That saves 141472 bytes