Add Debug trait to structs #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Member
|
utACK 89b4a7e |
danielabrozzoni
approved these changes
Jul 27, 2022
afilini
added a commit
to bitcoindevkit/bdk
that referenced
this pull request
Aug 29, 2022
138acc3 Change `populate_test_db` to not return empty input (wszdexdrf) d6e1dd1 Change CI to add test using ledger emulator (wszdexdrf) 7603477 Add a custom signer for hardware wallets (wszdexdrf) Pull request description: Also adds a new test in CI for building and testing on a virtual hardware wallet. ### Description This PR would enable BDK users to sign transactions using a hardware wallet. It is just the beginning hence there are no complex features, but I hope not for long. I have added a test in CI for building a ledger emulator and running the new test on it. The test is similar to the one on bitcoindevkit/rust-hwi. ### Notes to the reviewers The PR is incomplete (and wouldn't work, as the rust-hwi in `cargo.toml` is pointing to a local crate, temporarily) as a small change is required in rust-hwi (bitcoindevkit/rust-hwi#42). ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### New Features: * [x] I've added tests for the new feature * [x] I've added docs for the new feature * [x] I've updated `CHANGELOG.md` ACKs for top commit: afilini: ACK 138acc3 Tree-SHA512: 54337f06247829242b4dc60f733346173d957de8e9f8b80beb91304d679cfb4e0e4db722c967469265a5b6ede2bd641ba5c089760391c671995dc30de37897de
binary-hunter347iu
added a commit
to binary-hunter347iu/rust-hwi
that referenced
this pull request
Sep 28, 2025
89b4a7e816f7b2c18a8ba8204ccce0bcd2716329 Add Debug trait to structs (wszdexdrf)
Pull request description:
This is needed for bdk signer
ACKs for top commit:
danielabrozzoni:
utACK 89b4a7e816f7b2c18a8ba8204ccce0bcd2716329
Tree-SHA512: 9ac44f2c60ee303caa0adc864842ec716e066bf264dc3324b2a92dcd316d47a68656c3465ea89739bc8821b5b565a2164ab082d7abca1384888b8f345ad9a07c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for bdk signer