Skip to content

Update CI #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2022
Merged

Update CI #31

merged 2 commits into from
Jun 22, 2022

Conversation

@danielabrozzoni
Copy link
Member

@danielabrozzoni danielabrozzoni commented Jun 20, 2022

No description provided.

@danielabrozzoni
Remove unused dependencies from Cargo.toml
bb240fe
@danielabrozzoni
Update CI
f13c42b 
- The docker images only start the emulators, the testing is done
  outside the image
- Test both the latest rust version and the MSRV
- Add protobuf to the requirements.txt, as it's needed for CI to run
  properly (I suppose it's needed for most systems as well)
@danielabrozzoni danielabrozzoni marked this pull request as ready for review June 20, 2022 17:06
@danielabrozzoni danielabrozzoni mentioned this pull request Jun 20, 2022
Merged
wszdexdrf
wszdexdrf approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@wszdexdrf wszdexdrf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK f13c42b

@danielabrozzoni danielabrozzoni merged commit fb33164 into bitcoindevkit:master Jun 22, 2022
danielabrozzoni added a commit that referenced this pull request Jun 22, 2022
@danielabrozzoni
Merge #30: Update README.md, add CONTRIBUTING.md, update docs
983c057 
5a5cdca Small docs updates (Daniela Brozzoni)
4202320 Derive useful methods (Daniela Brozzoni)
4b0ade7 Add CONTRIBUTING.md (Daniela Brozzoni)
f68bae6 Update README.md (Daniela Brozzoni)

Pull request description:

  Based on #31
  Closes #28

ACKs for top commit:
  danielabrozzoni:
    self-ACK 5a5cdca

Tree-SHA512: db2500aa7520fe1772352e8d1053e34ba06dd11a5a83e6cbf5372f74bcd982e9908447a3e50f9afec76d5a360edca8de250b488b97b479ca94243cec3409c65b
binary-hunter347iu added a commit to binary-hunter347iu/rust-hwi that referenced this pull request Sep 28, 2025
@binary-hunter347iu
Merge bitcoindevkit/rust-hwi#31: Update CI
403a855 
f13c42b50ee38dabb2bdb9965abc54fcf2624032 Update CI (Daniela Brozzoni)
bb240fe3f6e33edbcbee2e1e0fab7e6304b1a698 Remove unused dependencies from Cargo.toml (Daniela Brozzoni)

Pull request description:

ACKs for top commit:
  wszdexdrf:
    Tested ACK f13c42b50ee38dabb2bdb9965abc54fcf2624032

Tree-SHA512: a887f5f1aeaf2b2a0a6a49cc59b673354caaa9e8ab0133b497069068aa0a776a16f5915564c0b40b614e8935e2e7342fba1a9477b19c64a11a5a3e7af737e221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wszdexdrf wszdexdrf wszdexdrf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielabrozzoni @wszdexdrf