Add togglepassphrase function #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wszdexdrf
force-pushed
the
togglepassphrase
branch
2 times, most recently
from
b05cf9c to
bd8a024
Compare
Contributor
Author
|
Should this test be ignored? |
wszdexdrf
force-pushed
the
togglepassphrase
branch
4 times, most recently
from
c6434e6 to
0cf80e5
Compare
src/lib.rs
Outdated
| fn test_toggle_passphrase() { | ||
| let devices = HWIClient::enumerate().unwrap(); | ||
| for device in devices { | ||
| if device.device_type == "ledger" { |
Member
There was a problem hiding this comment.
ACK for the approach, but the ledger is not the only device with this problem. It's the only device we test with this problem.
https://hwi.readthedocs.io/en/latest/devices/index.html#support-matrix
wszdexdrf
force-pushed
the
togglepassphrase
branch
2 times, most recently
from
2831fa3 to
8743caf
Compare
Also adds test for toggle_passphrase
wszdexdrf
force-pushed
the
togglepassphrase
branch
from
8743caf to
fe184f1
Compare
Member
|
ACK fe184f1 |
binary-hunter347iu
added a commit
to binary-hunter347iu/rust-hwi
that referenced
this pull request
Sep 28, 2025
fe184f11084756e61315b7afe3224d12561d0797 Add function for toggle_passphrase (wszdexdrf)
Pull request description:
ACKs for top commit:
danielabrozzoni:
ACK fe184f11084756e61315b7afe3224d12561d0797
Tree-SHA512: f9857fa36b9196f059fdf28a1b87eb90c55499d51e61e051b7da03c568a2ee6fc0daacd349af44c0c7ab2acfba5ddc6090b6f29621d931495a336a5cbb8ffcc4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.