Add debug flag equivalent #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/interface.rs
Outdated
| /// Set logging level | ||
| /// # Arguments | ||
| /// * `debug` - Print debug statements if true. | ||
| pub fn set_debug(debug: bool) -> Result<(), Error> { |
Member
There was a problem hiding this comment.
Maybe we could instead have a set_log_level, so that the users can set their preferred log level (warn, debug, info, error...)
wszdexdrf
force-pushed
the
debug
branch
5 times, most recently
from
4090bdc to
856ed48
Compare
Member
|
Can you change 856ed48's message? You're adding a function for setting the logging level |
Also adds a test for setting log level to DEBUG
Member
|
ACK b58cf80 |
binary-hunter347iu
added a commit
to binary-hunter347iu/rust-hwi
that referenced
this pull request
Sep 28, 2025
b58cf80b7b3dc4d7e86acd04e40fde90a284348f Add function for setting log level (wszdexdrf)
Pull request description:
This adds a function set_debug which will lower log levels to DEBUG so that more messages are logged.
ACKs for top commit:
danielabrozzoni:
ACK b58cf80b7b3dc4d7e86acd04e40fde90a284348f
Tree-SHA512: a3c1700a540a8014b291a00f3171e14be11f25f0bf62e368ef9fabb2898a62784e69fbc03b4264720797832ffe09365f204d58439ba32549889f10ac830b6b05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a function set_debug which will lower log levels to DEBUG so that more messages are logged.