Skip to content

chore(release): bump version to 0.24.0 and update CHANGELOG.md #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2025
Merged

chore(release): bump version to 0.24.0 and update CHANGELOG.md #174

merged 2 commits into from
Jul 30, 2025

Conversation

oleonardolima
Copy link
Contributor

@oleonardolima oleonardolima commented Jul 29, 2025 •
edited
Loading

fixes #173

  • bump the crate version to 0.24.0.
  • updates the CHANGELOG.md with relevant changes: 0.24.0...HEAD

@oleonardolima oleonardolima self-assigned this Jul 29, 2025
@oleonardolima oleonardolima force-pushed the release/bump-version-to-0.23.2 branch from c2c0779 to 8f658cc Compare July 29, 2025 23:38
@oleonardolima oleonardolima marked this pull request as ready for review July 29, 2025 23:38
@oleonardolima oleonardolima moved this to Needs Review in BDK Wallet Jul 29, 2025
@oleonardolima oleonardolima moved this to Needs Review in BDK Chain Jul 29, 2025
ValuedMammal
ValuedMammal approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8f658cc

ValuedMammal
ValuedMammal requested changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that ElectrumApi is a public trait, so should this be a bump to 0.24.0?

@notmandatory
Copy link
Member

I'm fine with 0.23.2 or 0.24.0, the semantic versioning spec doesn't set any rules about how to bump the version for pre-1.0 releases; https://semver.org/#spec-item-4.

@oleonardolima
Copy link
Contributor Author

I realized that ElectrumApi is a public trait, so should this be a bump to 0.24.0?

Oh, you're right! It's considered a minor change, as per https://doc.rust-lang.org/cargo/reference/semver.html#item-new. I think it's best to use 0.24.0 then.

@oleonardolima oleonardolima force-pushed the release/bump-version-to-0.23.2 branch from 8f658cc to 24d07e2 Compare July 30, 2025 14:44
@oleonardolima oleonardolima changed the title chore(release): bump version to 0.23.2 and update CHANGELOG.md chore(release): bump version to 0.24.0 and update CHANGELOG.md Jul 30, 2025
@ValuedMammal
Copy link
Contributor

ACK 24d07e2

@ValuedMammal ValuedMammal merged commit b20d41a into bitcoindevkit:master Jul 30, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Chain Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValuedMammal ValuedMammal ValuedMammal approved these changes

@notmandatory notmandatory Awaiting requested review from notmandatory

@LagginTimes LagginTimes Awaiting requested review from LagginTimes

Assignees

@oleonardolima oleonardolima

Labels
None yet
Projects
BDK Chain
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

release: electrum-client 0.24.0
3 participants
@oleonardolima @notmandatory @ValuedMammal