Skip to content

Revert "errors if expecing headers notification but not subscribed"#115

Merged
danielabrozzoni merged 1 commit into
bitcoindevkit:masterfrom
RCasatta:revert_headers
Aug 3, 2023
Merged

Revert "errors if expecing headers notification but not subscribed"#115
danielabrozzoni merged 1 commit into
bitcoindevkit:masterfrom
RCasatta:revert_headers

Conversation

@RCasatta
Copy link
Copy Markdown
Member

This reverts commit b86f2bb.

Some errors started to happen in downstream tests after this commit

#114

This reverts commit b86f2bb.

Some errors started to happen in downstream tests after this commit
@RCasatta RCasatta marked this pull request as ready for review July 21, 2023 13:39
Copy link
Copy Markdown
Member

@danielabrozzoni danielabrozzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2d44350

@danielabrozzoni danielabrozzoni merged commit ed9bb09 into bitcoindevkit:master Aug 3, 2023
radiant-smith-lk20 added a commit to radiant-smith-lk20/rust-electrum-client that referenced this pull request Dec 15, 2025
…ing headers notification but not subscribed"

2d44350b4445c457ea61f72ba2b42621bc3232b2 Revert "errors if expecing headers notification but not subscribed" (Riccardo Casatta)

Pull request description:

  This reverts commit b86f2bb22c293a5380febd0f1cd2f67a5fd92403.

  Some errors started to happen in downstream tests after this commit

  #114

ACKs for top commit:
  danielabrozzoni:
    utACK 2d44350b4445c457ea61f72ba2b42621bc3232b2

Tree-SHA512: d31174055f4245cc9d99f336b166a44271067b8daecaf2bb55d507ecfa4eb557b9802d576742fba59fd4dfda3f45fc76f02d7896af31353f19fc3a38698ac5a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants