Merged
Conversation
Collaborator
|
Built this PR bindings successfully locally. Imported those local bindings into the Xcode project successfully. Haven't used any of the big api changes (but wasn't using them previously yet in the app yet either) yet, but looking at the code changes they look right from what we discussed yesterday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplified FFI API to use strings for arguments and return values. Also removed parameters like SATSCARD new slot when the lib can figure out on it's own which one to use.
Notes to the reviewers
Thanks to @reez for helping me make this simpler.
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: