Add support for 'nfc' and 'xpub' commands#47
Merged
notmandatory merged 7 commits intomasterfrom Sep 1, 2025
Merged
Conversation
notmandatory
changed the title
notmandatory
force-pushed
the
feat/nfc
branch
from
443c4a0 to
c9826bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for the 'nfc' and 'xpub' commands in the lib, cli, and ffi bindings. Updates cli
signfor TAPSIGNER and SATSCHIP to sign a PSBT instead of a message.Closes: #16
Closes: #17
Notes to the reviewers
This is based on #46 and I'll rebase after that PR is merged.
Changelog notice
nfcandxpubcommands in the lib, cli, and ffi bindings.signcommand for TAPSIGNER and SATSCHIP to sign a PSBT instead of a digest.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: